Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for starting kubelet with a CSI volume mounted #118097

Merged
merged 2 commits into from
May 24, 2023
Merged

Add test for starting kubelet with a CSI volume mounted #118097

merged 2 commits into from
May 24, 2023

Conversation

jsafrane
Copy link
Member

@jsafrane jsafrane commented May 18, 2023 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

To have a regression tests for #117745, i.e. restart kubelet with a CSI volume mounted and the API server running as a static pod. We expect that the API server (or any other static pod) starts.

The test heavily uses kind containers and the fact that it runs the API server as a static pod.

I am adding it to sig-storage tests, I won't object if someone adds more similar tests and moves it to sig-node.

Which issue(s) this PR fixes:

Related to #117745

Special notes for your reviewer:

High level plan:

  1. Add this e2e test
  2. Create new periodic + optional pull CI jobs that runs a kind cluster + this e2e test (--focus=[Feature:Kind]): Add sig-storage job that uses KIND test-infra#29544
  3. Create a PR that enables NewVolumeManagerReconstruction, this test should fail.
  4. Create a PR that enables NewVolumeManagerReconstruction + Fix reconstruction of CSI volumes #117804, this test should succeed.
  5. Merge 4.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 18, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2023
@k8s-ci-robot k8s-ci-robot added area/test sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 18, 2023
@jsafrane jsafrane mentioned this pull request May 18, 2023
Merged
pohly
pohly suggested changes May 19, 2023
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see how this has to make some assumptions about how KinD operates, but it doesn't seem too bad to me.

test/e2e/storage/static_pods.go Outdated Show resolved Hide resolved
test/e2e/storage/static_pods.go Outdated Show resolved Hide resolved
test/e2e/storage/static_pods.go Outdated Show resolved Hide resolved
test/e2e/storage/static_pods.go Show resolved Hide resolved
@jsafrane
Add test for starting kubelet with a CSI volume mounted
b30720f 
To test kubernetes#117745,
restart kubelet with a CSI volume mounted *and* the API server running as a
static pod.

The test heavily uses `kind` containers and the fact that it uses the API
server as a static pod.
pohly
pohly reviewed May 23, 2023
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise looks good.

@jsafrane @pohly
Simplify DeferCleanup.
149f487 
Co-authored-by: Patrick Ohly <patrick.ohly@intel.com>
@pohly
Copy link
Contributor

pohly commented May 24, 2023

/retest
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b897c1d95f946258af9879661fde0e7190f864ea

@k8s-ci-robot k8s-ci-robot merged commit ddf958e into kubernetes:master May 24, 2023
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 24, 2023
@jsafrane jsafrane mentioned this pull request Jun 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly requested changes

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@pohly pohly

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jsafrane @k8s-ci-robot @pohly